Error lines from build-log.txt
... skipping 2995 lines ...
go: downloading github.com/golang/protobuf v1.5.3
go: downloading github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e
go: downloading github.com/prometheus/common v0.32.1
go: downloading github.com/prometheus/procfs v0.7.3
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
[34;1m🐱[0m running golangci-lint…
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/hcl/scanner/scanner.go:125:18: Error return value of `s.buf.UnreadRune` is not checked (errcheck)
s.buf.UnreadRune()
^
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/json/scanner/scanner.go:115:18: Error return value of `s.buf.UnreadRune` is not checked (errcheck)
s.buf.UnreadRune()
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/client.go:1451:15: Error return value of `limiter.Wait` is not checked (errcheck)
limiter.Wait(ctx)
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/client.go:1639:15: Error return value of `limiter.Wait` is not checked (errcheck)
limiter.Wait(ctx)
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/sys_raft.go:246:11: Error return value of `io.Copy` is not checked (errcheck)
io.Copy(ioutil.Discard, rPipe)
^
third_party/VENDOR-LICENSE/github.com/hashicorp/errwrap/errwrap.go:55:22: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(
format, "{{err}}", outerMsg, -1)` (gocritic)
outer := errors.New(strings.Replace(
^
... skipping 76 lines ...
if lit == "true" || lit == "false" {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/lifetime_watcher.go:106:2: deprecatedComment: use `Deprecated: ` (note the casing) instead of `DEPRECATED: ` (gocritic)
// DEPRECATED: this does not do anything.
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/plugin_runtime_types.go:24:29: captLocal: `PluginRuntimeType' should not be capitalized (gocritic)
func ParsePluginRuntimeType(PluginRuntimeType string) (PluginRuntimeType, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/request.go:66:1: deprecatedComment: use `Deprecated: ` (note the casing) instead of `DEPRECATED: ` (gocritic)
// DEPRECATED: ToHTTP turns this request into a valid *http.Request for use
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/secret.go:192:14: appendAssign: append result not assigned to the same slice (gocritic)
policies := append(tokenPolicies, identityPolicies...)
... skipping 119 lines ...
"crypto/sha1"
^
third_party/VENDOR-LICENSE/github.com/letsencrypt/boulder/goodkey/weak.go:61:10: G401: Use of weak cryptographic primitive (gosec)
hash := sha1.Sum([]byte(fmt.Sprintf("Modulus=%X\n", key.N.Bytes())))
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:91:3: unreachable: unreachable code (govet)
panic("undefined sort order for remaining items in the list")
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/client.go:1029:8: copylocks: assignment copies lock value to c2: github.com/tektoncd/cli/third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api.Client contains sync.RWMutex (govet)
c2 := *c
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/client.go:1708:8: copylocks: assignment copies lock value to c2: github.com/tektoncd/cli/third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api.Client contains sync.RWMutex (govet)
c2 := *c
... skipping 77 lines ...
cap = uint64(inp)
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-secure-stdlib/parseutil/parseutil.go:88:3: redefines-builtin-id: redefinition of the built-in function cap (revive)
cap = uint64(inp)
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-secure-stdlib/parseutil/parseutil.go:436:40: redefines-builtin-id: redefinition of the built-in function min (revive)
func SafeParseIntRange(in interface{}, min int64, max int64) (int64, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:17:15: var-declaration: should omit type *regexp.Regexp from declaration of var signRE; it will be inferred from the right-hand side (revive)
signRE *regexp.Regexp = regexp.MustCompile(`^[\s]*[+-]`)
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:18:15: var-declaration: should omit type *regexp.Regexp from declaration of var whitespaceRE; it will be inferred from the right-hand side (revive)
whitespaceRE *regexp.Regexp = regexp.MustCompile(`[\s]+`)
... skipping 7 lines ...
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:48:49: unexported-return: exported func OrderedIfAddrBy returns unexported type *sockaddr.multiIfAddrSorter, which can be annoying to use (revive)
func OrderedIfAddrBy(cmpFuncs ...CmpIfAddrFunc) *multiIfAddrSorter {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:207:38: var-naming: don't use underscores in Go names; func parameter type_ should be type (revive)
func FilterIfByType(ifAddrs IfAddrs, type_ SockAddrType) (matchedIfs, excludedIfs IfAddrs) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ipv4addr.go:232:10: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
} else {
return sortDeferDecision
}
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ipv6addr.go:237:10: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
} else {
return sortDeferDecision
}
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ipv6addr.go:293:1: receiver-naming: receiver name x should be consistent with previous receiver name ipv6 for IPv6Addr (revive)
func (x IPv6Addr) ContainsNetwork(y IPv6Addr) bool {
{
... skipping 32 lines ...
return false
}
return true
}
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/route_info_linux.go:16:22: unexported-return: exported func NewRouteInfo returns unexported type sockaddr.routeInfo, which can be annoying to use (revive)
func NewRouteInfo() (routeInfo, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/sockaddr.go:9:6: exported: type name will be used as sockaddr.SockAddrType by other packages, and that stutters; consider calling this Type (revive)
type SockAddrType int
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/sockaddr.go:132:6: exported: func name will be used as sockaddr.SockAddrAttr by other packages, and that stutters; consider calling this Attr (revive)
func SockAddrAttr(sa SockAddr, selector AttrName) string {
... skipping 27 lines ...
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/decoder.go:21:11: var-declaration: should omit type reflect.Type from declaration of var nodeType; it will be inferred from the right-hand side (revive)
nodeType reflect.Type = findNodeType()
^
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/hcl/parser/parser.go:49:5: var-naming: var errEofToken should be errEOFToken (revive)
var errEofToken = errors.New("EOF token found")
^
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/hcl/parser/parser.go:251:22: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
Err: errors.New("no object keys found!"),
^
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/hcl/strconv/quote.go:83:11: superfluous-else: if block ends with a break statement, so drop this else and outdent its block (revive)
} else {
// If there's more left, we need to pop back up to the top of the loop
// in case there's another interpolation in this string.
... skipping 39 lines ...
operator_end
^
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/lex.go:13:2: var-naming: const lexModeJson should be lexModeJSON (revive)
lexModeJson
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/auth_token.go:318:64: unused-parameter: parameter 'token' seems to be unused, consider removing or renaming it as _ (revive)
func (c *TokenAuth) RevokeSelfWithContext(ctx context.Context, token string) error {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/client.go:118:2: var-naming: struct field HttpClient should be HTTPClient (revive)
HttpClient *http.Client
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/client.go:283:41: unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive)
config.HttpClient.CheckRedirect = func(req *http.Request, via []*http.Request) error {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/client.go:1788:43: redefines-builtin-id: redefinition of the built-in function new (revive)
func MergeReplicationStates(old []string, new string) []string {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/logical.go:247:46: unused-parameter: parameter 'path' seems to be unused, consider removing or renaming it as _ (revive)
func (c *Logical) write(ctx context.Context, path string, request *Request) (*Secret, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/sys_raft.go:324:41: context-keys-type: should not use basic type string as key in context.WithValue (revive)
return c.RaftAutopilotStateWithContext(context.WithValue(context.Background(), "dr-token", drToken))
^
third_party/VENDOR-LICENSE/github.com/hashicorp/vault/api/sys_raft.go:372:49: context-keys-type: should not use basic type string as key in context.WithValue (revive)
return c.RaftAutopilotConfigurationWithContext(context.WithValue(context.Background(), "dr-token", drToken))
... skipping 2 lines ...
func RetryBackoff(retries int, base, max time.Duration, factor float64) time.Duration {
^
third_party/VENDOR-LICENSE/github.com/letsencrypt/boulder/identifier/identifier.go:6:6: exported: type name will be used as identifier.IdentifierType by other packages, and that stutters; consider calling this Type (revive)
type IdentifierType string
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:1182:6: func parseDefaultIfNameFromRoute is unused (unused)
func parseDefaultIfNameFromRoute(routeOut string) (string, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:1217:6: func parseDefaultIfNameFromIPCmdAndroid is unused (unused)
func parseDefaultIfNameFromIPCmdAndroid(routeOut string) (string, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:1249:6: func parseDefaultIfNameWindows is unused (unused)
func parseDefaultIfNameWindows(routeOut, ipconfigOut string) (string, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:1274:6: func parseDefaultIPAddrWindowsRoute is unused (unused)
func parseDefaultIPAddrWindowsRoute(routeOut string) (string, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/go-sockaddr/ifaddrs.go:1298:6: func parseDefaultIfNameWindowsIPConfig is unused (unused)
func parseDefaultIfNameWindowsIPConfig(defaultIPAddr, routeOut string) (string, error) {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/golang-lru/testing.go:10:6: func getRand is unused (unused)
func getRand(tb testing.TB) int64 {
^
third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/hcl/parser/parser.go:21:2: field commaPrev is unused (unused)
commaPrev token.Token
... skipping 23 lines ...
* gosec: 30
* govet: 4
* ineffassign: 11
* misspell: 4
* revive: 57
* unused: 13
make: *** [Makefile:104: lint-go] Error 1
==============================
==== GO LINT TESTS FAILED ====
==============================
+ EXIT_VALUE=1
+ set +o xtrace
